fix: TypeScript's option checking return value should be noImplicitReturns#700
Closed
stefafafan wants to merge 1 commit intobasarat:masterfrom
Closed
fix: TypeScript's option checking return value should be noImplicitReturns#700stefafafan wants to merge 1 commit intobasarat:masterfrom
noImplicitReturns#700stefafafan wants to merge 1 commit intobasarat:masterfrom
Conversation
anandfresh
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This following portion of the documentation is incorrect, strictNullChecks does not have to do with the
"not all code paths return a value"check, it is noImplicitReturns that checks this.Playground example:
strictNullChecksis off: https://www.typescriptlang.org/play/?strictNullChecks=false#code/JYOwLgpgTgZghgYwgAgMoEcCucooN4BQyxyA1qACYBcyARAM5Y4S0DcRJ9wAXhDSJgC2AI2jsAvgQKhIsRCgBKEBGDggA5gBt8HYuRDU6uFWq0t2JZAHdgFMAAt+Q0VAsl7EYOvtgnIsQSS0uDQ8EjIAMLAUAjayISW+oa0CNGx5rrIUHAUwJj0fi4SUmAAngAOKKj2cJXIALxoTLjIAD7ISiYace1RMdrsBDCYICrAAPYgyMxwABQFaDWVAJTxmfQ2YAj2yPMAdEmrCZYkCHD0KAzNLDS4YJhQU-R7XLzIAFTIz68QbifIZwuRmUqm6NyyEHujy+exsdh2n2eHi8Pj+J0Bl1S-XBdweUwAsnAHHsAAoASQ+MOyuXylOe1Ly9DRlgoEHgmE0vky-wQk3oYGQAH0IAAPGr5MDAABuEAiHgQpH4EBlUAaXzRknEQANot all code paths return a value.strictNullChecksis on: https://www.typescriptlang.org/play/?#code/JYOwLgpgTgZghgYwgAgMoEcCucooN4BQyxyA1qACYBcyARAM5Y4S0DcRJ9wAXhDSJgC2AI2jsAvgQKhIsRCgBKEBGDggA5gBt8HYuRDU6uFWq0t2JZAHdgFMAAt+Q0VAsl7EYOvtgnIsQSS0uDQ8EjIAMLAUAjayISW+oa0CNGx5rrIUHAUwJj0fi4SUmAAngAOKKj2cJXIALxoTLjIAD7ISiYace1RMdrsBDCYICrAAPYgyMxwABQFaDWVAJTxmfQ2YAj2yPMAdEmrCZYkCHD0KAzNLDS4YJhQU-R7XLzIAFTIz68QbifIZwuRmUqm6NyyEHujy+exsdh2n2eHi8Pj+J0Bl1S-XBdweUwAsnAHHsAAoASQ+MOyuXylOe1Ly9DRlgoEHgmE0vky-wQk3oYGQAH0IAAPGr5MDAABuEAiHgQpH4EBlUAaXzRknEQANot all code paths return a value.noImplicitReturnsis off: https://www.typescriptlang.org/play/?noImplicitReturns=false#code/JYOwLgpgTgZghgYwgAgMoEcCucooN4BQyxyA1qACYBcyARAM5Y4S0DcRJ9wAXhDSJgC2AI2jsAvgQKhIsRCgBKEBGDggA5gBt8HYuRDU6uFWq0t2JZAHdgFMAAt+Q0VAsl7EYOvtgnIsQSS0uDQ8EjIAMLAUAjayISW+oa0CNGx5rrIUHAUwJj0fi4SUmAAngAOKKj2cJXIALxoTLjIAD7ISiYace1RMdrsBDCYICrAAPYgyMxwABQFaDWVAJTxmfQ2YAj2yPMAdEmrCZYkCHD0KAzNLDS4YJhQU-R7XLzIAFTIz68QbifIZwuRmUqm6NyyEHujy+exsdh2n2eHi8Pj+J0Bl1S-XBdweUwAsnAHHsAAoASQ+MOyuXylOe1Ly9DRlgoEHgmE0vky-wQk3oYGQAH0IAAPGr5MDAABuEAiHgQpH4EBlUAaXzRknEQA